Bug 270245
Summary: | [Win] run-bindings-tests: FAILURE: Determination of whether there is an interface or callback interface from regular expression based parser (YES) doesn't match the determination from validation parser (NO) | ||
---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> |
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Fujii Hironori
run-bindings-tests fails on my PC. It works fine on WinCairo buildbot.
> PS C:\webkit> python Tools/Scripts/run-bindings-tests
> FAILURE: Determination of whether there is an interface or callback interface from regular expression based parser (YES) doesn't match the determination from validation parser (NO) [WebCore\bindings\scripts\test\DedicatedWorkerGlobalScope.idl]. at WebCore/bindings/scripts/preprocess-idls.pl line 790.
>
> Failed to generate a supplemental dependency file.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Fujii Hironori
I have CC=clang-cl env var.
preprocessor.pm uses only /EP flag for Windows.
https://github.com/WebKit/WebKit/blob/76811693b10007dba19a08e3395e0c072c4bc0be/Source/WebCore/bindings/scripts/preprocessor.pm#L51
But, clang-cl complains:
> clang-cl /EP .\a.idl
clang-cl: warning: .\a.idl: 'linker' input unused [-Wunused-command-line-argument]
CMake is using "/nologo /EP /TP" flags.
https://github.com/WebKit/WebKit/blob/76811693b10007dba19a08e3395e0c072c4bc0be/Source/cmake/WebKitCompilerFlags.cmake#L316
It works.
> clang-cl /nologo /EP /TP .\a.idl
[Exposed=DedicatedWorker] interface DedicatedWorkerGlobalScope : WorkerGlobalScope {
};
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/25271
EWS
Committed 275477@main (4adc8868a3aa): <https://commits.webkit.org/275477@main>
Reviewed commits have been landed. Closing PR #25271 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/123805595>