Bug 27010

Summary: Need to remove UsesManualToJSImplementation() in favor of CustomToJS
Product: WebKit Reporter: Andrew Wilson <atwilson>
Component: WebCore JavaScriptAssignee: Andrew Wilson <atwilson>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch darin: review+

Andrew Wilson
Reported 2009-07-06 15:24:09 PDT
CodeGeneratorJS.pm has some hard-coded logic which determines whether a toJS() function should be defined in the JS binding header file, and whether an implementation should be automatically generated. This logic is: .h file: define toJS() if the class in question is a base class (no parent class) or if it has the GenerateToJS custom attribute. .cpp file: automatically generate implementation of toJS() if the class in question is a base class, but is not a member of a hardcoded list in UsesManualToJSImplementation() We should get rid of UsesManualToJSImplementation() in favor of a CustomToJS attribute - the presence of this attribute will cause the code generator to emit a toJS() definition in the generated .h file, but will not automatically generate an implementation in the .cpp file.
Attachments
Proposed patch (6.56 KB, patch)
2009-07-06 17:18 PDT, Andrew Wilson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Wilson
Comment 1 2009-07-06 17:18:57 PDT
Created attachment 32334 [details] Proposed patch
Darin Adler
Comment 2 2009-07-06 17:26:02 PDT
Comment on attachment 32334 [details] Proposed patch r=me assuming it build and tests pass
Dmitry Titov
Comment 3 2009-07-10 12:15:30 PDT
Landed: http://trac.webkit.org/changeset/45714
Note You need to log in before you can comment on or make changes to this bug.