Bug 27005

Summary: Build fixes when NETSCAPE_PLUGIN_API is disabled
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 ggaren: review+

David Kilzer (:ddkilzer)
Reported 2009-07-06 14:21:38 PDT
Created attachment 32322 [details] Patch v1 Build fixes when NETSCAPE_PLUGIN_API is disabled Reviewed by NOBODY (OOPS!). * Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): Wrap call to ScriptController::cleanupScriptObjectsForPlugin() in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginController destroyAllPlugins]): Ditto. * Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Wrap WebBaseNetscapePluginView class checks in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginDatabase destroyAllPluginInstanceViews]): Ditto.
Attachments
Patch v1 (4.79 KB, patch)
2009-07-06 14:21 PDT, David Kilzer (:ddkilzer) 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2009-07-06 19:44:56 PDT
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/mac/ChangeLog M WebKit/mac/Plugins/WebPluginController.mm M WebKit/mac/Plugins/WebPluginDatabase.mm Committed r45583 http://trac.webkit.org/changeset/45583
Note You need to log in before you can comment on or make changes to this bug.