Bug 269825

Summary: REGRESSION(274325@main): Find matches can not be selected after calling `findMatchesForString`
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: New BugsAssignee: Charlie Wolfe <charliew>
Status: RESOLVED FIXED    
Severity: Normal CC: charliew, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2024-02-20 18:40:44 PST 
Hi Team,

I am noticing following issue in Minibrowser and at least - I think it is recent regression:

1) Open 'Minibrowser'
2) Go to any website or page:

e.g., https://github.com/WebKit/WebKit/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+author%3AAhmad-S792

3) Search for keyword via Command+F - which has more than one instances (e.g., 'Remove')
4) Now with focus already in 'Find' - Press 'Enter'

Expected Result (in Safari):

Move to next instance of search result and move page as needed to find the search result

Actual Result (in Minibrowser):

Search remain stuck

Just wanted to raise it.

Thanks!
Comment 1 Simon Fraser (smfr) 2024-02-21 13:49:47 PST 
Yes please
Comment 2 Charlie Wolfe 2024-02-22 13:16:08 PST 
Seems likely I broke this. I'll take a look.
Comment 3 Radar WebKit Bug Importer 2024-02-22 13:16:46 PST 
<rdar://problem/123465751>
Comment 4 Charlie Wolfe 2024-02-22 15:43:03 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24982
Comment 5 EWS 2024-02-22 21:35:01 PST 
Committed 275219@main (467125332e14): <https://commits.webkit.org/275219@main>

Reviewed commits have been landed. Closing PR #24982 and removing active labels.