Bug 269754
| Summary: | REGRESSION(274288@main): Null pointer dereference in `WebPageProxy::activityStateDidChange()` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Wolfe <charliew> |
| Component: | WebKit Misc. | Assignee: | Charlie Wolfe <charliew> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Charlie Wolfe
`m_pageClient` is protected in `decidePolicyForNavigationAction()`, but not passed to the created lambdas. When `Transaction` is destructed, `activityStateDidChange()` tries to create a strong reference to `m_pageClient`, but it may already be destroyed. We should pass `protectedPageClient` into the lambdas where `Transaction` is used.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Charlie Wolfe
rdar://123032571
Charlie Wolfe
Pull request: https://github.com/WebKit/WebKit/pull/24778
EWS
Committed 275019@main (350492890293): <https://commits.webkit.org/275019@main>
Reviewed commits have been landed. Closing PR #24778 and removing active labels.