Bug 269752

Summary: AX: Implement support for serving AXRangeForLine off the main-thread
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tyler Wilcock
Reported 2024-02-19 14:11:08 PST
...
Attachments
Patch (27.17 KB, patch)
2024-02-19 16:14 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-19 14:11:20 PST
<rdar://problem/123266666>
Tyler Wilcock
Comment 2 2024-02-19 16:14:47 PST
Created attachment 469980 [details] Patch
Andres Gonzalez
Comment 3 2024-02-20 06:16:00 PST
Looks good. Would it be possible to do the equivalent of toTextRunMarker when we create an AXTextMarker? That way we wouldn't have to do this all over the place. In other words, does it make sense to have an AXTextMarker that !isInTextRun() in the first place?
Tyler Wilcock
Comment 4 2024-02-20 08:53:55 PST
(In reply to Andres Gonzalez from comment #3) > Looks good. Would it be possible to do the equivalent of toTextRunMarker > when we create an AXTextMarker? That way we wouldn't have to do this all > over the place. In other words, does it make sense to have an AXTextMarker > that !isInTextRun() in the first place? This is a very good question! I would say in the code's current state, I think we could what you're suggesting. However, I'm still personally expecting for a case for a non-text-run marker to make itself evident (e.g. the core editing logic has "anchor" / "tree" positions). If the need does not arise for those as we continue this work, we should make the change you're suggesting. Thanks for the review.
EWS
Comment 5 2024-02-20 09:59:15 PST
Committed 275050@main (e19b5bf8775e): <https://commits.webkit.org/275050@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469980 [details].
Note You need to log in before you can comment on or make changes to this bug.