Bug 26967

Summary:

[V8] Move garbage collector related functions from V8Proxy to V8GCController

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	eric: review+

Adam Barth

Reported 2009-07-04 08:48:00 PDT

static void gcProtect(void* domObject); static void gcUnprotect(void* domObject); class DOMObjectVisitor class EnsureWeakDOMNodeVisitor class GCPrologueVisitor class GrouperItem class ObjectGrouperVisitor static void gcPrologue class GCEpilogueVisitor static void gcEpilogue

Attachments
patch (19.68 KB, patch) 2009-07-08 15:04 PDT, Adam Barth	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-07-08 15:04:49 PDT

Created attachment 32477 [details] patch

Eric Seidel (no email)

Comment 2 2009-07-08 15:31:48 PDT

Comment on attachment 32477 [details] patch LGTM.

Adam Barth

Comment 3 2009-07-08 15:49:09 PDT

Sending WebCore/ChangeLog Sending WebCore/bindings/v8/NPV8Object.cpp Sending WebCore/bindings/v8/ScheduledAction.cpp Sending WebCore/bindings/v8/ScriptController.cpp Sending WebCore/bindings/v8/ScriptInstance.cpp Sending WebCore/bindings/v8/ScriptValue.h Sending WebCore/bindings/v8/V8AbstractEventListener.cpp Sending WebCore/bindings/v8/V8LazyEventListener.cpp Sending WebCore/bindings/v8/V8NodeFilterCondition.cpp Sending WebCore/bindings/v8/V8Proxy.cpp Sending WebCore/bindings/v8/V8Proxy.h Sending WebCore/bindings/v8/custom/V8CustomEventListener.cpp Transmitting file data ............ Committed revision 45646.

Note You need to log in before you can comment on or make changes to this bug.