Bug 269545
| Summary: | Return initial value for `stop-color` instead of `transparentBlack` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking into `stop-color` failures, I noticed that we return `transparentBlack', while I think it would be better to return `Color:Black` since it is initial value as per web-spec:
Web-Spec: https://svgwg.org/svg2-draft/pservers.html#StopColorProperties
Initial: Black
Our current code: https://searchfox.org/wubkat/rev/c40451f6052e2805fb1c6abfb61fa322c67caf5b/Source/WebCore/svg/SVGStopElement.cpp#90
We should change it to `Color:black`.
transparentBlack -> static constexpr auto transparentBlack = SRGBA<uint8_t> { };
While
black -> static constexpr auto black = SRGBA<uint8_t> { 0, 0, 0 };
Which makes more sense and aligned with web-spec.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 274997@main (dcd60b82e8d8): <https://commits.webkit.org/274997@main>
Reviewed commits have been landed. Closing PR #24583 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/123262508>