Bug 269472

Summary: REGRESSION(274694@main): Causes crashes when multiple threads are rendering PDF pages
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: lerica, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 268536    
Attachments:
Description Flags
REVERT of 274694@main none

Description WebKit Commit Bot 2024-02-15 09:35:07 PST
https://commits.webkit.org/274694@main introduced a regression:
Causes crashes when multiple threads are rendering PDF pages

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2024-02-15 09:35:13 PST
Created attachment 469883 [details]
REVERT of 274694@main

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Simon Fraser (smfr) 2024-02-15 09:36:38 PST
This caused crashes when rdar://119632313 is enabled, which causes multiple threads to be triggering loading at the same time. The "semaphore per request" is needed.
Comment 3 EWS 2024-02-15 09:41:34 PST
Committed 274738@main (c030c01b1e1b): <https://commits.webkit.org/274738@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 469883 [details].
Comment 4 Radar WebKit Bug Importer 2024-02-15 09:42:21 PST
<rdar://problem/123019776>