Summary: | Increase delay in worker-terminate layout test to make it more reliable. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dmitry Titov
2009-07-01 22:24:39 PDT
Created attachment 32169 [details]
Proposed patch
Comment on attachment 32169 [details]
Proposed patch
R=me, but it sure would be nice if there were a way to construct a
test that wasn't timing sensitive. Adding delays to the layout
tests just slows down running all of the layout tests, and if 500ms
wasn't enough, then sometimes (maybe only rarely) 1000ms will also
not be enough.
(In reply to comment #2) > (From update of attachment 32169 [details] [review]) > R=me, but it sure would be nice if there were a way to construct a > test that wasn't timing sensitive. Absolutely. There is a separate discussion on how to test termination of workers (dedicated and shared) - seems we'll need to implement additional API on layoutTestController since the GC and actual destruction of workers is intentionally designed to be undetectable from a 'normal' page. Do we have a follow-up bug about termination testing? |