Bug 269147 – [GTK][WPE] Build fails with ENABLE_VIDEO=OFF

• Component: WebKitGTK
• Status: ASSIGNED

[Mart Raudsepp]

Created attachment 469808 [details]
Log of failure with disabled gstreamer build options

Trying further after bug 269144 and bug 269145 to disable the whole gstreamer dep and see how WebKitGTK is doing instead of WPE, looks like ENABLE_VIDEO or similar is failing as well (same kind of error happens with WPE build as well).
This is a build combination that would be nice to have working, as I maintain that option in Gentoo, but if not, we can force gstreamer as well for now. Though eventually it got fixed and working in 2.42 series while being broken earlier, so I guess someone cares about it, so here's a report on it failing again in git main

[Mart Raudsepp]

I believe this might just be missing a
WEBKIT_OPTION_DEPEND(ENABLE_VIDEO ENABLE_MEDIA_STREAM)
in OptionsGTK.cmake or higher up

[Mart Raudsepp]

And
WEBKIT_OPTION_DEPEND(ENABLE_VIDEO ENABLE_WEB_CODECS)
then too.

[Mart Raudsepp]

Sorry, the ENABLE_MEDIA_STREAM one was already there (apparently it's written the other way around as `WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_STREAM ENABLE_VIDEO)` in WebKitFeatures.cmake), so this was a regression from 

commit 1aa24c14332324946e8aa737eb45aaba51485cd8
Author: Pablo Saavedra <[e-mail]>
Date:   Wed Mar 1 14:51:55 2023 -0800

    Complement Enable HTMLCanvasElement::toVideoFrame with Web Codecs
    https://bugs.webkit.org/show_bug.cgi?id=252759


where ENABLE(WEB_CODECS) made VideoFrame referenced as well, but nothing ensuring VideoFrame is actually there.

[Michael Catanzaro]

ENABLE_VIDEO is not supposed to depend on ENABLE_WEB_CODECS.

ENABLE_WEB_CODECS is probably supposed to depend on ENABLE_VIDEO.

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/61165