Summary: | [GTK] [WPE] git main build fails with -DENABLE_VIDEO=OFF | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mart Raudsepp <leio> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | bugs-noreply, mcatanzaro, psaavedra | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mart Raudsepp
2024-02-10 13:38:08 PST
I believe this might just be missing a WEBKIT_OPTION_DEPEND(ENABLE_VIDEO ENABLE_MEDIA_STREAM) in OptionsGTK.cmake or higher up And WEBKIT_OPTION_DEPEND(ENABLE_VIDEO ENABLE_WEB_CODECS) then too. Sorry, the ENABLE_MEDIA_STREAM one was already there (apparently it's written the other way around as `WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_STREAM ENABLE_VIDEO)` in WebKitFeatures.cmake), so this was a regression from commit 1aa24c14332324946e8aa737eb45aaba51485cd8 Author: Pablo Saavedra <psaavedra@igalia.com> Date: Wed Mar 1 14:51:55 2023 -0800 Complement Enable HTMLCanvasElement::toVideoFrame with Web Codecs https://bugs.webkit.org/show_bug.cgi?id=252759 where ENABLE(WEB_CODECS) made VideoFrame referenced as well, but nothing ensuring VideoFrame is actually there. ENABLE_VIDEO is not supposed to depend on ENABLE_WEB_CODECS. ENABLE_WEB_CODECS is probably supposed to depend on ENABLE_VIDEO. |