Summary: | Need to enable CHANNEL_MESSAGING by default | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wilson <atwilson> | ||||||||
Component: | WebKit API | Assignee: | Andrew Wilson <atwilson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, dimich | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Andrew Wilson
2009-07-01 13:48:19 PDT
Created attachment 32152 [details]
Proposed patch
This patch is actually much smaller than it appears - I've re-enabled a bunch of the previously disabled tests (I didn't modify them, I just renamed them) which makes it look large.
Comment on attachment 32152 [details]
Proposed patch
This enables channel messaging for Xcode and for autoconf builds - are any changes to Windows Visual Studio project files necessary?
It would be nice to add a few words about why we're turning CHANNEL_MESSAGING on (e.g. "because the MessageChannel API can now be implemented for Web Workers, and is reasonably stable thus").
Created attachment 32461 [details]
Patch addressing ap's comments
Good catch on the visual studio stuff - I've done a search to make sure I haven't missed any other places, and also updated the ChangeLogs to have a less terse change description.
Comment on attachment 32461 [details] Patch addressing ap's comments > +<<<<<<< HEAD:LayoutTests/ChangeLog > +======= Please fix conflict markers before landing. Does the Visual Studio project actually build? I'm not sure if it has all the necessary source files in it. Oh, and please also enable LayoutTests/http/tests/security/MessagePort/event-listener-context.html-disabled. I'm going to say r=me now, but please address these comments. Created attachment 32523 [details]
Patch with enabled security test and removing merge conflict.
Sigh, fixed merge errors - tragically git didn't notice that I'd committed a file with a merge conflict.
I enabled that test - as I mentioned on IRC, you can no longer use a MessageChannel constructor from a closed frame, so now I simplified the test to just check for a thrown exception.
I was able to build on Windows just fine - what files were you concerned were missing from the vcproj file?
Comment on attachment 32523 [details]
Patch with enabled security test and removing merge conflict.
r=me
|