Bug 26896

Summary: [QT] make layout tests in fast/css/getComputedStyle/ to pass
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 26886    
Attachments:
Description Flags
patch hausmann: review+

Description Antonio Gomes 2009-07-01 12:21:43 PDT 
Right now fast/css/getComputedStyle/computed-style-font-family.html fails.

 Font attributes. The font-family should list three families:
 
 font-family: monospace, 'Lucida Grande', sans-serif;
-font-size: 13px;
+font-size: 14px;
 font-style: normal;
 font-variant: normal;
 font-weight: normal;

we have set QWebSetting::DefaultFontSize to 14 , intentionally, so plan here is to "fix" DRT to use 13 , which is what is expected by the test results...
Comment 1 Antonio Gomes 2009-07-01 13:15:55 PDT 
Created attachment 32137 [details]
patch

patch for the bug. It was reviewed by Adam Treat on IRC:
<manyoso> r=me
<manyoso> on condition of one change!
<manyoso> you have to add the bug report URL to the ChangeLog and check-in
<manyoso> thanks!
Comment 2 Eric Seidel (no email) 2009-07-01 19:06:28 PDT 
Comment on attachment 32137 [details]
patch

Please don't mark it as reviewed unless you're a reviewer. :(  Makes the scripts unhappy.

If Adam Marks this himself someone else can easily commit it.  Otherwise he'll need to come take care of commiting for you..
Comment 3 Simon Hausmann 2009-07-02 07:15:14 PDT 
Comment on attachment 32137 [details]
patch

Looks good, tried, works. And this time touches only Qt files :)
Comment 4 Simon Hausmann 2009-07-02 07:15:53 PDT 
Landed in r45473