Bug 268918

Summary:	Update RenderText::text() to return a String instead of a StringImpl
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	Layout and Rendering	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Chris Dumez

Reported 2024-02-07 08:11:23 PST

Update RenderText::text() to return a String instead of a StringImpl. It is safer to deal with Strings than with StringImpl pointers directly. There is also zero performance difference on Speedometer 2 & 3.

Attachments
Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2024-02-07 08:14:02 PST

Pull request: https://github.com/WebKit/WebKit/pull/24006

EWS

Comment 2 2024-02-07 10:02:01 PST

Committed 274220@main (c3d587ae8216): <https://commits.webkit.org/274220@main> Reviewed commits have been landed. Closing PR #24006 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-02-07 10:03:19 PST

<rdar://problem/122477708>

Note You need to log in before you can comment on or make changes to this bug.