Bug 268827

Summary: [upload-file-to-url] Add Content-Type
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 268495    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2024-02-06 08:15:48 PST
By default, upload-file-to-url uploads everything as an octet stream. This is often correct, but when, for example, uploading build logs, we want to set the content type to be 'plain/text'. More generally, we want callers to be able to specify the Content-Type used by upload-file-to-url, along with making some reasonable educated guesses based on file extension.
Attachments
Patch (2.96 KB, patch)
2024-02-06 08:21 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.94 KB, patch)
2024-02-06 08:49 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2024-02-06 10:23 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-06 08:16:55 PST
<rdar://problem/122390338>
Jonathan Bedard
Comment 2 2024-02-06 08:18:32 PST
Pull request: https://github.com/WebKit/WebKit/pull/23922
Jonathan Bedard
Comment 3 2024-02-06 08:21:06 PST
Created attachment 469747 [details] Patch
Jonathan Bedard
Comment 4 2024-02-06 08:49:39 PST
Created attachment 469748 [details] Patch
Jonathan Bedard
Comment 5 2024-02-06 08:56:31 PST
We shouldn't make reasonable guesses, since for signed S3 URLs, the content-type must exactly match. This means that the caller must specify the content type explicitly, otherwise we can expect surprising errors.
Jonathan Bedard
Comment 6 2024-02-06 10:23:27 PST
Created attachment 469750 [details] Patch
EWS
Comment 7 2024-02-06 10:38:48 PST
Committed 274156@main (b563a0725168): <https://commits.webkit.org/274156@main> Reviewed commits have been landed. Closing PR #23922 and removing active labels.
EWS
Comment 8 2024-02-06 11:49:20 PST
Committed 272448.504@safari-7618-branch (5fb0f7715eb9): <https://commits.webkit.org/272448.504@safari-7618-branch> Reviewed commits have been landed. Closing PR #1062 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.