Bug 268790

Summary: detik.com: Menu text is not shown in safari at top left corner of header
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
[fast-cq]Patch none

alan
Reported 2024-02-05 16:29:27 PST
<rdar://60358063>
Attachments
Patch (3.91 KB, patch)
2024-02-05 16:38 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2024-02-05 20:33 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq]Patch (4.83 KB, patch)
2024-02-06 07:11 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-02-05 16:38:27 PST
Created attachment 469732 [details] Patch
alan
Comment 2 2024-02-05 20:33:54 PST
Created attachment 469735 [details] Patch
Antti Koivisto
Comment 3 2024-02-06 07:02:43 PST
Comment on attachment 469735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=469735&action=review > Source/WebCore/rendering/RenderBlock.cpp:2309 > + auto childAvoidsFloats = (is<RenderBox>(*child) && downcast<RenderBox>(*child).avoidsFloats()) || (child->isAnonymousBlock() && child->childrenInline()); This could do dynamicDowncast<RenderBox> first for readability
alan
Comment 4 2024-02-06 07:11:21 PST
Created attachment 469746 [details] [fast-cq]Patch
EWS
Comment 5 2024-02-06 07:16:34 PST
Commit message contains (OOPS!) and no reviewer found, blocking PR #None
EWS
Comment 6 2024-02-06 19:12:16 PST
Committed 274191@main (0e458e89455f): <https://commits.webkit.org/274191@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469746 [details].
Note You need to log in before you can comment on or make changes to this bug.