Bug 26878

Summary:

Incorrect event.keyIdentifier value for F10 and F11 keys

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, solushex, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
patch	darin: review+, commit-queue: commit-queue-

Yury Semikhatsky

Reported 2009-06-30 23:55:54 PDT

Steps to reproduce: 1. Load the following HTML Chrome or Safari on Windows. <html> <body onkeydown="alert('event.keyIdentifier = ' + event.keyIdentifier);"> </body> </html> 2. Press F10 and F11 keys Result: For F10 key you'll see event.keyIdentifier = F11 alert For F11 key it will be event.keyIdentifier = U+005A

Attachments
patch (1.02 KB, patch) 2011-12-28 19:29 PST, rahul abrol	darin: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

rahul abrol

Comment 1 2011-12-28 19:29:56 PST

Created attachment 120715 [details] patch added missing f10 and f11 entries.

WebKit Review Bot

Comment 2 2011-12-28 19:31:26 PST

Attachment 120715 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 3 2011-12-28 19:45:52 PST

Comment on attachment 120715 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=120715&action=review > b/Source/WebCore/ChangeLog:8 > + No new tests required. Why not?

rahul abrol

Comment 4 2011-12-28 22:38:44 PST

(In reply to comment #3) > (From update of attachment 120715 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120715&action=review > > > b/Source/WebCore/ChangeLog:8 > > + No new tests required. > > Why not? i don't have the source tree on this machine :-\

Darin Adler

Comment 5 2013-05-08 09:11:16 PDT

Comment on attachment 120715 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=120715&action=review > b/Source/WebCore/ChangeLog:1 > +2011-12-28 Rahul Abrol <solushex@gmail.com> This line is formatted incorrectly. >>> b/Source/WebCore/ChangeLog:8 >>> + No new tests required. >> >> Why not? > > i don't have the source tree on this machine :-\ So it’s wrong to say “no new tests required”. The change log would be better without this comment.

WebKit Commit Bot

Comment 6 2013-05-08 09:38:01 PDT

Comment on attachment 120715 [details] patch Rejecting attachment 120715 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 120715, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 149741 = 15972cccde39a3cae0119ab06d4b009fd3a1b76b r149742 = 3ee31df2f3c5f56992db99f868a87f2b746f11b5 r149743 = e69d6637a7718f1baa7118e3fc51122fc1b0d5e8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/408428

EWS

Comment 7 2022-10-06 13:25:45 PDT

Committed 255238@main (25a848ab9af4): <https://commits.webkit.org/255238@main> Reviewed commits have been landed. Closing PR #5054 and removing active labels.

Radar WebKit Bug Importer

Comment 8 2022-10-06 13:26:25 PDT

<rdar://problem/100867561>

Note You need to log in before you can comment on or make changes to this bug.