Bug 268753
| Summary: | Webrtc decoder MediaCapabilities powerEfficient value is incorrect | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> |
| Component: | WebRTC | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
youenn fablet
Webrtc decoder MediaCapabilities powerEfficient value is incorrect since we disabled VTB APIs in WebProcess.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/122316664>
youenn fablet
Pull request: https://github.com/WebKit/WebKit/pull/23868
EWS
Committed 274358@main (b19ff0f84cdb): <https://commits.webkit.org/274358@main>
Reviewed commits have been landed. Closing PR #23868 and removing active labels.
Diego Pino
This change broke the build for WPE/WebKitGTK with LibWebRTC:
https://build.webkit.org/#/builders/2/builds/8652
FAILED: In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-18.cpp:6:
../../../Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp: In member function ‘virtual bool WebKit::LibWebRTCProvider::isSupportingVP9HardwareDecoder() const’:
../../../Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp:86:36: error: ‘class WebKit::WebProcess’ has no member named ‘libWebRTCCodecs’
86 | return WebProcess::singleton().libWebRTCCodecs().isSupportingVP9HardwareDecoder();
| ^~~~~~~~~~~~~~~
../../../Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp: In member function ‘virtual void WebKit::LibWebRTCProvider::setVP9HardwareSupportForTesting(std::optional<bool>)’:
../../../Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp:91:29: error: ‘class WebKit::WebProcess’ has no member named ‘libWebRTCCodecs’
91 | WebProcess::singleton().libWebRTCCodecs().setVP9HardwareSupportForTesting(value);
| ^~~~~~~~~~~~~~~
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/24206
EWS
Committed 274423@main (e790e23b5624): <https://commits.webkit.org/274423@main>
Reviewed commits have been landed. Closing PR #24206 and removing active labels.