Bug 268659

Summary:	New Tests(273949@main): [ Release ] API tests TestWebKitAPI.WKWebExtensionAPIStorage.* are constantly timing out or failing.
Product:	WebKit	Reporter:	Ben Schwartz <ben_schwartz>
Component:	WebKit Extensions	Assignee:	Brian Weinstein <bweinstein>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	timothy, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=268565

Ben Schwartz

Reported 2024-02-02 13:21:21 PST

The following API tests are timing out on release queues: TestWebKitAPI.WKWebExtensionAPIStorage.Clear TestWebKitAPI.WKWebExtensionAPIStorage.Get TestWebKitAPI.WKWebExtensionAPIStorage.GetBytesInUse TestWebKitAPI.WKWebExtensionAPIStorage.Remove TestWebKitAPI.WKWebExtensionAPIStorage.Set TestWebKitAPI.WKWebExtensionAPIStorage.StorageAreaOnChanged TestWebKitAPI.WKWebExtensionAPIStorage.StorageOnChanged The following API test is failing on release queues: TestWebKitAPI.WKWebExtensionAPIStorage.SetCustomObject HISTORY: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WKWebExtensionAPIStorage.SetCustomObject&test=TestWebKitAPI.WKWebExtensionAPIStorage.Clear&test=TestWebKitAPI.WKWebExtensionAPIStorage.Get&test=TestWebKitAPI.WKWebExtensionAPIStorage.GetBytesInUse&test=TestWebKitAPI.WKWebExtensionAPIStorage.Remove&test=TestWebKitAPI.WKWebExtensionAPIStorage.Set&test=TestWebKitAPI.WKWebExtensionAPIStorage.SetCustomObject&test=TestWebKitAPI.WKWebExtensionAPIStorage.StorageAreaOnChanged&test=TestWebKitAPI.WKWebExtensionAPIStorage.StorageOnChanged FAIL TEXT (for failing test): TestWebKitAPI.WKWebExtensionAPIStorage.SetCustomObject webkit-extension://83474a5d-6064-45e7-b9d5-375219cac3ac/background.js:20Function threw an exception: "Invalid call to storageArea.set(). The 'items[`(null)`]' value is invalid, because exceeded maximum size for a single item." REGRESSION: This issue first appeared after the tests were introduced at 273949@main.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-02-02 13:22:03 PST

<rdar://problem/122202826>

Brian Weinstein

Comment 2 2024-02-02 14:32:32 PST

Pull request: https://github.com/WebKit/WebKit/pull/23778

EWS

Comment 3 2024-02-02 14:41:13 PST

Committed 274018@main (cff46c9c95c7): <https://commits.webkit.org/274018@main> Reviewed commits have been landed. Closing PR #23778 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.