Bug 268650

Summary: REGRESSION(273934@main): [ Debug ] Multiple layout tests crashing.
Product: WebKit Reporter: Ben Schwartz <ben_schwartz>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: ntim, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=268063
Attachments:
Description Flags
crashing-thread.txt
none
crash-data.ips none

Description Ben Schwartz 2024-02-02 11:55:41 PST 
Multiple tests are crashing following the changes at 273934@main, impacting EWS queues.

Example test: imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo.html

CRASH LOG:

ASSERTION FAILED: !collector.matchedPseudoElementIds()
/Volumes/Data/worker/macOS-AppleSilicon-Sonoma-Debug-Build-EWS/build/Source/WebCore/style/StyleResolver.cpp(482) : std::optional<ResolvedStyle> WebCore::Style::Resolver::styleForPseudoElement(const Element &, const PseudoElementRequest &, const ResolutionContext &)
1   0x13bf1dbfc WTFCrash
2   0x2a7d07a20 WebCore::AudioWorkletProcessor::buildJSArguments(JSC::VM&, JSC::JSGlobalObject&, JSC::MarkedVector<JSC::JSValue, 8ul, WTF::RecordOverflow>&, WTF::Vector<WTF::RefPtr<WebCore::AudioBus, WTF::RawPtrTraits<WebCore::AudioBus>, WTF::DefaultRefDerefTraits<WebCore::AudioBus>>, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WTF::Vector<WTF::Ref<WebCore::AudioBus, WTF::RawPtrTraits<WebCore::AudioBus>, WTF::DefaultRefDerefTraits<WebCore::AudioBus>>, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WTF::HashMap<WTF::String, std::__1::unique_ptr<WebCore::AudioArray<float>, std::__1::default_delete<WebCore::AudioArray<float>>>, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::unique_ptr<WebCore::AudioArray<float>, std::__1::default_delete<WebCore::AudioArray<float>>>>, WTF::MemoryCompactLookupOnlyRobinHoodHashTableTraits> const&)
3   0x2aab4c008 WebCore::Style::Resolver::styleForPseudoElement(WebCore::Element const&, WebCore::Style::PseudoElementRequest const&, WebCore::Style::ResolutionContext const&)
4   0x2a8b07a74 WebCore::Document::styleForElementIgnoringPendingStylesheets(WebCore::Element&, WebCore::RenderStyle const*, std::__1::optional<WebCore::Style::PseudoElementIdentifier> const&)
5   0x2a8c133c0 WebCore::Element::resolvePseudoElementStyle(WebCore::Style::PseudoElementIdentifier const&)
...
(full attached)

REGRESSION: This issue began at 273934@main.
Comment 1 Radar WebKit Bug Importer 2024-02-02 11:56:01 PST 
<rdar://problem/122199019>
Comment 2 Ben Schwartz 2024-02-02 11:56:54 PST 
Created attachment 469679 [details]
crashing-thread.txt
Comment 3 Ben Schwartz 2024-02-02 11:57:26 PST 
Created attachment 469680 [details]
crash-data.ips
Comment 4 Tim Nguyen (:ntim) 2024-02-02 12:34:21 PST 
Pull request: https://github.com/WebKit/WebKit/pull/23773
Comment 5 EWS 2024-02-02 12:56:02 PST 
Committed 274010@main (ea774f9f202d): <https://commits.webkit.org/274010@main>

Reviewed commits have been landed. Closing PR #23773 and removing active labels.