Bug 268626
| Summary: | Fix SharedMemoryUnix link with librt | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, aperez, cdumez, loic.yhuel, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=268521 | ||
Olivier Blin
In 273951@main, SharedMemoryUnix has been moved from WebKit to WebCore.
Since it uses shm_open(), the matching librt test should be moved in WebCore cmake files.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Olivier Blin
Pull request: https://github.com/WebKit/WebKit/pull/23746
Olivier Blin
It failed with this error:
[22/68] Linking CXX executable bin/TestWebKitAPI/TestWebCore
FAILED: bin/TestWebKitAPI/TestWebCore
: && /usr/bin/clang++-12 -stdlib=libc++ -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -fno-rtti -gsplit-dwarf -g -L/home/sah0146/vc/webkit.org/WebKit/WebKitBuild/DependenciesWPE/Root/lib -Wl,--disable-new-dtags @CMakeFiles/TestWebCore.rsp -o bin/TestWebKitAPI/TestWebCore && :
/usr/bin/ld: Source/WebCore/CMakeFiles/WebCore.dir/./__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-77.cpp.o: undefined reference to symbol 'shm_open@@GLIBC_2.2.5'
/usr/bin/ld: /lib/x86_64-linux-gnu/librt.so.1: error adding symbols: DSO missing from command line
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Michael Catanzaro
*** This bug has been marked as a duplicate of bug 268619 ***
EWS
Committed 274015@main (1eb09af23ff7): <https://commits.webkit.org/274015@main>
Reviewed commits have been landed. Closing PR #23746 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/122203867>