Bug 268620
| Summary: | SVGStyleSheet tests fails while CSSOM passes on `StyleSheet_property_values` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking into WPT Test cases failure, I noticed that we fail `SVG` one while passing CSS one.
So just raising so we can investigate and fix it.
WPT Test Case (Live Link) - http://wpt.live/svg/styling/style-sheet-interfaces.svg
WPT Test Case: https://wpt.fyi/results/svg/styling/style-sheet-interfaces.svg?label=master&label=experimental&aligned
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Interesting stuff in Web-standard:
https://drafts.csswg.org/cssom/#requirements-on-user-agents-implementing-the-xml-stylesheet-processing-instruction
Ahmad Saleem
We do fail on `ownerNode` and if I look into `CSSStyleSheet` Interface:
https://drafts.csswg.org/cssom/#the-stylesheet-interface
Web-Spec says:
readonly attribute (Element or ProcessingInstruction)? ownerNode;
While we have:
readonly attribute Node ownerNode;
___
We don't have it nullable and also not taking ProcessingInstruction into account. I know in the past, I learnt that ProcessingInstruction is also node type. So it is covered by Node but I remember looking into Mozilla Firefox and Chromium / Blink and it was nullable at least.
Radar WebKit Bug Importer
<rdar://problem/122574381>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/59770
EWS
Committed 308980@main (f54bd14d6787): <https://commits.webkit.org/308980@main>
Reviewed commits have been landed. Closing PR #59770 and removing active labels.