Bug 268615

Summary:	[LBSE] Code cleanup after implementing all but one resource
Product:	WebKit	Reporter:	Nikolas Zimmermann <zimmermann>
Component:	SVG	Assignee:	Nikolas Zimmermann <zimmermann>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	rbuis, sabouhallawa, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	90738, 265134

Nikolas Zimmermann

Reported 2024-02-02 04:02:39 PST

There are still numerous references to SVGResources/SVGResourcesCache etc. We should remove all of that legacy code in LBSE-only renderers, and turn all the static SVGResourcesCache methods like clientWasAddedToTree, clientStyleChanged, clientLayoutChanged, etc to RELEASE_ASSERT_NOT_REACHED() if LBSE is active.

Attachments
Add attachment proposed patch, testcase, etc.

Nikolas Zimmermann

Comment 1 2024-02-02 06:05:35 PST

Pull request: https://github.com/WebKit/WebKit/pull/23740

EWS

Comment 2 2024-02-03 15:58:28 PST

Committed 274053@main (a3c7518b1394): <https://commits.webkit.org/274053@main> Reviewed commits have been landed. Closing PR #23740 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-02-03 15:59:13 PST

<rdar://problem/122247380>

Note You need to log in before you can comment on or make changes to this bug.