Bug 268594
| Summary: | [SVG2] getPointAtLength should throw exception when "path" is empty and renderable display type | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, karlcow, sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
We seems to fail few more "SVGGeometry" tests:
WPT Test Cases: https://wpt.fyi/results/svg/types/scripted/SVGGeometryElement.getPointAtLength-04.svg?label=master&label=experimental&aligned=&q=safari%3Afail
It is for when we don't have 'display: none' and 'display: contents', we have 'rendererIsNeeded' function, which might suite to be used in following two functions but I have tried adding in '.h' with both 'true' and 'false' values but it didn't work.
Second issue is about 'path' being empty:
WPT Test Case: https://wpt.fyi/results/svg/types/scripted/SVGGeometryElement.getPointAtLength-05.svg?label=master&label=experimental&aligned=&q=safari%3Afail
I have tried:
Path path();
if (path.isEmpty())
return Exception {};
or
if (path().isEmpty())
or
if (pathByteStream().isEmpty())
__
It progress few tests but then it leads to failure in other tests, so we need to do both stuff in one go.
Just raising so we can track it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/122574451>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/32623
EWS
Committed 282665@main (6b8f14839b07): <https://commits.webkit.org/282665@main>
Reviewed commits have been landed. Closing PR #32623 and removing active labels.