Bug 268555

Summary:	REGRESSION ( 272208@main?): [ iOS 17 Debug ] http/wpt/webcodecs/h264-encoder-default-config.https.any.html (layout test) is a constant crash
Product:	WebKit	Reporter:	Jay Stfleur <j_stfleur>
Component:	WebRTC	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Jay Stfleur

Reported 2024-02-01 09:05:39 PST

Description: http/wpt/webcodecs/h264-encoder-default-config.https.any.html Is a constant crash. Started crashing on/after 272208@main History: https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fwebcodecs%2Fh264-encoder-default-config.https.any.html Diff/Image Diff/Crash Log: https://build.webkit.org/results/Apple-iOS-17-Simulator-Debug-WK2-Tests/273889@main%20(931)/http/wpt/webcodecs/h264-encoder-default-config.https.any-crash-log.txt

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-02-01 09:06:22 PST

<rdar://problem/122107461>

Jay Stfleur

Comment 2 2024-02-01 11:00:45 PST

Reproducibility: Not able to reproduce

Jay Stfleur

Comment 3 2024-02-01 11:10:25 PST

Pull request: https://github.com/WebKit/WebKit/pull/23681

EWS

Comment 4 2024-02-01 12:00:18 PST

Test gardening commit 273929@main (67209ab8769e): <https://commits.webkit.org/273929@main> Reviewed commits have been landed. Closing PR #23681 and removing active labels.

Alexey Proskuryakov

Comment 5 2024-02-05 10:36:05 PST

ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/worker/Apple-iOS-17-Simulator-Debug-Build/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/CompletionHandler.h(65) : WTF::CompletionHandler<void (bool)>::~CompletionHandler() 1 0x10694aca4 WTFCrash 2 0x13a897a28 WTF::CompletionHandler<void (bool)>::~CompletionHandler() 3 0x13acfdc9c WTF::CompletionHandler<void (bool)>::~CompletionHandler() 4 0x13a7ab7d8 WTF::VectorDestructor<true, WTF::CompletionHandler<void (bool)>>::destruct(WTF::CompletionHandler<void (bool)>*, WTF::CompletionHandler<void (bool)>*) 5 0x13a7ab774 WTF::VectorTypeOperations<WTF::CompletionHandler<void (bool)>>::destruct(WTF::CompletionHandler<void (bool)>*, WTF::CompletionHandler<void (bool)>*) 6 0x13a7ab67c WTF::Deque<WTF::CompletionHandler<void (bool)>, 0ul>::destroyAll() 7 0x13a7ab2e4 WTF::Deque<WTF::CompletionHandler<void (bool)>, 0ul>::~Deque() 8 0x13a7ab2a0 WTF::Deque<WTF::CompletionHandler<void (bool)>, 0ul>::~Deque() 9 0x13a7ab268 WebKit::LibWebRTCCodecsProxy::Encoder::~Encoder() 10 0x13a7a1224 WebKit::LibWebRTCCodecsProxy::Encoder::~Encoder() 11 0x13a7a2e8c WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>::~KeyValuePair() 12 0x13a7a2e20 WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>::~KeyValuePair() 13 0x13a7a2da8 WTF::HashTable<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>>, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashMap<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>>::deallocateTable(WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>*) 14 0x13a7a2c54 WTF::HashTable<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>>, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashMap<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>>::~HashTable() 15 0x13a7a2bf8 WTF::HashTable<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder>>, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashMap<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>>::~HashTable() 16 0x13a7a2bcc WTF::HashMap<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::HashTableTraits>::~HashMap() 17 0x13a79e5a0 WTF::HashMap<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>, WebKit::LibWebRTCCodecsProxy::Encoder, WTF::DefaultHash<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WTF::ObjectIdentifierGeneric<WebKit::VideoEncoderIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits>>, WTF::HashTraits<WebKit::LibWebRTCCodecsProxy::Encoder>, WTF::HashTableTraits>::~HashMap() 18 0x13a7ad1c8 WebKit::LibWebRTCCodecsProxy::stopListeningForIPC(WTF::Ref<WebKit::LibWebRTCCodecsProxy, WTF::RawPtrTraits<WebKit::LibWebRTCCodecsProxy>, WTF::DefaultRefDerefTraits<WebKit::LibWebRTCCodecsProxy>>&&)::$_10::operator()() const 19 0x13a7acfa0 WTF::Detail::CallableWrapper<WebKit::LibWebRTCCodecsProxy::stopListeningForIPC(WTF::Ref<WebKit::LibWebRTCCodecsProxy, WTF::RawPtrTraits<WebKit::LibWebRTCCodecsProxy>, WTF::DefaultRefDerefTraits<WebKit::LibWebRTCCodecsProxy>>&&)::$_10, void>::call() 20 0x10697509c WTF::Function<void ()>::operator()() const 21 0x106ac06c8 WTF::(anonymous namespace)::DispatchWorkItem::operator()() 22 0x106abf388 void WTF::dispatchWorkItem<WTF::(anonymous namespace)::DispatchWorkItem>(void*)

youenn fablet

Comment 6 2024-02-20 07:33:48 PST

Should be fixed by https://commits.webkit.org/274828@main. We might need to update the test expectations for both http/wpt/webcodecs/h264-encoder-default-config.https.any.html and http/wpt/webcodecs/h264-encoder-default-config.https.any.worker.html

EWS

Comment 7 2024-02-20 09:51:39 PST

Committed 275049@main (06df59ad1b4a): <https://commits.webkit.org/275049@main> Reviewed commits have been landed. Closing PR #24817 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.