Bug 268528 – Make the backing sharing logging more readable

• Component: Compositing
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

The Compositing log channel's logging for backing sharing is really hard to read:

Update 2 of main frame - compositing policy is normal
0x148000d40 s computeCompositingRequirements (backing provider candidates [])
BackingSharingState::updateBeforeDescendantTraversal: layer 0x148000d40 will be composited 1
  0x148001c30 s computeCompositingRequirements (backing provider candidates [])
BackingSharingState::updateBeforeDescendantTraversal: layer 0x148001c30 will be composited 0
    0x148003d70 n computeCompositingRequirements (backing provider candidates [])
BackingSharingState::updateBeforeDescendantTraversal: layer 0x148003d70 will be composited 1
RenderLayerCompositor::updateBackingSharingAfterDescendantTraversal for layer 0x148003d70 is composited 1
BackingSharingState::updateAfterDescendantTraversal: started sharing sequence with provider candidate 0x148003d70
    0x148003d70 computeCompositingRequirements - willBeComposited 1 (backing provider candidates [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 0])
    0x148004210 s computeCompositingRequirements (backing provider candidates [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 0])
 layer 0x148004210 can share with [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 1]
BackingSharingState::updateBeforeDescendantTraversal: layer 0x148004210 will be composited 0
      0x1480049a0 s computeCompositingRequirements (backing provider candidates [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 1])
BackingSharingState::updateBeforeDescendantTraversal: layer 0x1480049a0 will be composited 0
RenderLayerCompositor::updateBackingSharingAfterDescendantTraversal for layer 0x1480049a0 is composited 0
      0x1480049a0 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 1])
      0x1480044c0 s computeCompositingRequirements (backing provider candidates [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 1])
BackingSharingState::updateBeforeDescendantTraversal: layer 0x1480044c0 will be composited 0
RenderLayerCompositor::updateBackingSharingAfterDescendantTraversal for layer 0x1480044c0 is composited 0
      0x1480044c0 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 1])
RenderLayerCompositor::updateBackingSharingAfterDescendantTraversal for layer 0x148004210 is composited 0
    0x148004210 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 1])
RenderLayerCompositor::updateBackingSharingAfterDescendantTraversal for layer 0x148001c30 is composited 0
RenderLayerCompositor::updateBackingSharingAfterDescendantTraversal: End of stacking context for backing provider [provider RenderLayer 0x148003d70 790x622 RenderLayerBacking 0x10706dec0 bounds (0,0) width=0 height=0 primary layer ID 32 sharing layers 1]
  0x148001c30 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [])
RenderLayerCompositor::updateBackingSharingAfterDescendantTraversal for layer 0x148000d40 is composited 1
0x148000d40 computeCompositingRequirements - willBeComposited 1 (backing provider candidates [])

[Radar WebKit Bug Importer]

<rdar://problem/122066519>

[Simon Fraser (smfr)]

With the upcoming patch:

Update 2 of main frame - compositing policy is normal
0x167000d40 computeCompositingRequirements (backing provider candidates [])
0x167000d40 updateBackingSharingBeforeDescendantTraversal - will be composited 1
  0x167001c30 computeCompositingRequirements (backing provider candidates [])
  0x167001c30 updateBackingSharingBeforeDescendantTraversal - will be composited 0
    0x1670040b0 computeCompositingRequirements (backing provider candidates [])
    0x1670040b0 updateBackingSharingBeforeDescendantTraversal - will be composited 1
    0x1670040b0 updateBackingSharingAfterDescendantTraversal for layer - is composited 1
     - started sharing sequence with provider candidate 0x1670040b0
    0x1670040b0 computeCompositingRequirements - willBeComposited 1 (backing provider candidates [provider 0x1670040b0, sharing layers ])
    0x167004360 computeCompositingRequirements (backing provider candidates [provider 0x1670040b0, sharing layers ])
     0x167004360 can share with [provider 0x1670040b0, sharing layers 0x167004360]
    0x167004360 updateBackingSharingBeforeDescendantTraversal - will be composited 0
      0x167004af0 computeCompositingRequirements (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360])
      0x167004af0 updateBackingSharingBeforeDescendantTraversal - will be composited 0
        0x167004da0 computeCompositingRequirements (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360])
        0x167004da0 updateBackingSharingBeforeDescendantTraversal - will be composited 0
          0x167005050 computeCompositingRequirements (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360])
          0x167005050 updateBackingSharingBeforeDescendantTraversal - will be composited 0
          0x167005050 updateBackingSharingAfterDescendantTraversal for layer - is composited 0
          0x167005050 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360])
        0x167004da0 updateBackingSharingAfterDescendantTraversal for layer - is composited 0
        0x167004da0 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360])
Layer 0x167004af0 needs to repaint into potential backing-sharing layer, postponing repaint
      0x167004af0 updateBackingSharingAfterDescendantTraversal for layer - is composited 1
       - is composited; maybe ending existing backing sequence with candidates [provider 0x1670040b0, sharing layers 0x167004360] stacking context 0x167001c30
      0x167004af0 computeCompositingRequirements - willBeComposited 1 (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360])
    layer 0x167004360 was sharing now will composite
      0x167004610 computeCompositingRequirements (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360])
       0x167004610 can share with [provider 0x1670040b0, sharing layers 0x167004360, 0x167004610]
      0x167004610 updateBackingSharingBeforeDescendantTraversal - will be composited 0
      0x167004610 updateBackingSharingAfterDescendantTraversal for layer - is composited 0
      0x167004610 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004360, 0x167004610])
Layer 0x167004360 needs to repaint into potential backing-sharing layer, postponing repaint
    0x167004360 updateBackingSharingAfterDescendantTraversal for layer - is composited 1
     - is composited; maybe ending existing backing sequence with candidates [provider 0x1670040b0, sharing layers 0x167004610] stacking context 0x167001c30
    0x167004360 computeCompositingRequirements - willBeComposited 1 (backing provider candidates [provider 0x1670040b0, sharing layers 0x167004610])
  0x167001c30 updateBackingSharingAfterDescendantTraversal for layer - is composited 0
   - end of stacking context for backing provider [provider 0x1670040b0, sharing layers 0x167004610]
Issuing postponed repaint of layer 0x167004360
Issuing postponed repaint of layer 0x167004af0
  0x167001c30 computeCompositingRequirements - willBeComposited 0 (backing provider candidates [])
0x167000d40 updateBackingSharingAfterDescendantTraversal for layer - is composited 1
0x167000d40 computeCompositingRequirements - willBeComposited 1 (backing provider candidates [])

[Simon Fraser (smfr)]

Pull request: https://github.com/WebKit/WebKit/pull/23649

[EWS]

Committed 273940@main (dd64fd7b0ea1): <https://commits.webkit.org/273940@main>

Reviewed commits have been landed. Closing PR #23649 and removing active labels.