Bug 268471
| Summary: | [Site Isolation] If testRunner.notifyDone is called from a site isolated process layout test may not complete | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Reno <rreno> |
| Component: | WebKit Process Model | Assignee: | Ryan Reno <rreno> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=280403 | ||
Ryan Reno
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Reno
<rdar://problem/121682316>
Ryan Reno
Pull Request: https://github.com/WebKit/WebKit/pull/23589
Ryan Reno
There's a race condition between the main frame and a remote frame calling notifyDone. If the main frame's DocumentLoader makes its finished loading callbacks and checks in with the UIProcess' m_waitUntilDone variable (via the GetWaitUntilDone message) before the remote frame can write to the variable then we'll hang, waiting forever.
The fix is going to be identifying whether or not notifyDone is being called from a remote frame and if it is, sending the "Done" message to the UIProcess which will take care of notifying the main frame's WebContent process to wrap up the test.
Ryan Reno
Pull request: https://github.com/WebKit/WebKit/pull/23893
EWS
Committed 274211@main (2e5a9d342dc4): <https://commits.webkit.org/274211@main>
Reviewed commits have been landed. Closing PR #23893 and removing active labels.