Bug 268251
Summary: | Add support for SVGAElement's text attribute | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | frances_c, sabouhallawa, webkit-bug-importer, zimmermann |
Priority: | P2 | Keywords: | InRadar, WPTImpact |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://github.com/w3c/svgwg/issues/931 |
Ahmad Saleem
Hi Team,
It is to add parity to HTMLAnchorElement and it is in web-spec:
https://svgwg.org/svg2-draft/linking.html#InterfaceSVGAElement
It seems easy to add and progress two WPT test cases in 'svg/idlharness.window.html'.
I have local build with patch as well.
Just wanted to raise this so we can do this.
Thanks!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
>> Source/WebCore/svg/SVGAElement.cpp:
String SVGAElement::text()
{
return textContent();
}
void SVGAElement::setText(String&& text)
{
setTextContent(WTFMove(text));
}
>> Source/WebCore/svg/SVGAElement.h: (In public)
WEBCORE_EXPORT String text();
void setText(String&&);
>> Source/WebCore/svg/SVGAElement.idl:
[CEReactions=Needed] attribute DOMString text;
__
That's it.
Ahmad Saleem
@Frances - do you want to take this?
Ahmad Saleem
Might have to add:
>> Source/WebCore/svg/svgattrs.in:
'text' (without quotes) as well.
Ahmad Saleem
Might progress this as well:
https://wpt.fyi/results/svg/linking/scripted/a.text-setter-01.svg?label=master&label=experimental&aligned=&q=svg%2Flinking%2F
and
https://wpt.fyi/results/svg/linking/scripted/a.text-getter-01.svg?label=experimental&label=master&aligned=&q=svg%2Flinking%2F
Frances Cornwall
Yes, I will work on this today.
Frances Cornwall
Pull request: https://github.com/WebKit/WebKit/pull/23424
Frances Cornwall
Relating to: https://bugs.webkit.org/show_bug.cgi?id=268407
Radar WebKit Bug Importer
<rdar://problem/122268835>
Ahmad Saleem
As mentioned - https://github.com/w3c/svgwg/issues/931 - Firefox is removing this.
So WONTFIX.