Bug 267936
| Summary: | Element::parserSetAttributes shouldn't trigger shadow tree construction in TextFieldInputType::attributeChanged | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
We're always creating input element's shadow tree inside Element::parserSetAttributes because of this following code in TextFieldInputType:
```
void TextFieldInputType::attributeChanged(const QualifiedName& name)
{
if (name == valueAttr || name == placeholderAttr) {
if (element())
updateInnerTextValue();
}
InputType::attributeChanged(name);
}
```
Don't do that.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/23111
EWS
Committed 273461@main (66bf68c9f459): <https://commits.webkit.org/273461@main>
Reviewed commits have been landed. Closing PR #23111 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/121567802>