Bug 267827
| Summary: | Begin using C++ coroutines for WebPageProxy::decidePolicyForNavigationAction | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> |
| Component: | WebKit Process Model | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alex Christensen
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alex Christensen
Pull request: https://github.com/WebKit/WebKit/pull/23021
Radar WebKit Bug Importer
<rdar://problem/121762525>
EWS
Committed 278995@main (e90f899882e4): <https://commits.webkit.org/278995@main>
Reviewed commits have been landed. Closing PR #23021 and removing active labels.
Diego Pino
Build bot 'GTK-Linux-64-bit-Release-Debian-11-Build' if failing after this patch with the following error:
https://build.webkit.org/#/builders/992/builds/2441/steps/9/logs/stdio
```
In file included from ../../../Source/WebKit/Platform/CoroutineUtilities.h:31,
from ../../../Source/WebKit/UIProcess/WebPageProxy.cpp:70,
from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-9.cpp:2:
/usr/include/c++/10/coroutine:295:2: error: #error "the coroutine header requires -fcoroutines"
295 | #error "the coroutine header requires -fcoroutines"
| ^~~~~
In file included from ../../../Source/WebKit/UIProcess/WebPageProxy.cpp:70,
from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-9.cpp:2:
../../../Source/WebKit/Platform/CoroutineUtilities.h:48:42: error: expected ‘)’ before ‘<’ token
48 | CoroutineHandle(std::coroutine_handle<PromiseType>&& handle)
| ~ ^
| )
```
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/28833
EWS
Committed 279046@main (3a3bb5a411b2): <https://commits.webkit.org/279046@main>
Reviewed commits have been landed. Closing PR #28833 and removing active labels.