Bug 267615
| Summary: | `audio` element has two UA Stylesheet rules (html.css & mediaControls.css) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | eric.carlson, jer.noble, karlcow, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
I noted that we have two `audio` element UA stylesheet rules:
html.css:
https://github.com/WebKit/WebKit/blob/8948469628f6e2c8cd44d680b2f194371e9b3f97/Source/WebCore/css/html.css#L174
audio {
width: 200px;
height: 25px;
}
mediaControls.css
https://github.com/WebKit/WebKit/blob/8948469628f6e2c8cd44d680b2f194371e9b3f97/Source/WebCore/css/mediaControls.css#L31
audio {
width: 200px;
height: 16px;
}
__
Don't know which one to delete. Only difference is 'height'.
Any input?
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
NOTE - Web spec don't have any specified width and height for audio elements.
https://html.spec.whatwg.org/#embedded-content-rendering-rules
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/22846
Using 'html.css' as single source of truth.
EWS
Committed 273114@main (f2379cbda4fa): <https://commits.webkit.org/273114@main>
Reviewed commits have been landed. Closing PR #22846 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/121095621>