Bug 26752

Summary: Windows release build crashs on Qt 4.5.
Product: WebKit Reporter: Raju Kunnath <raju.kunnath>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Windows release build fix hausmann: review+

Raju Kunnath
Reported 2009-06-26 04:03:50 PDT
Windows release build crash on Qt 4.5. The crash happens on both msvc 2005 and msvc 2008. Repoducible: Build the NB webkit with qmake CONFIG+=release open qtlauncher
Attachments
Windows release build fix (994 bytes, patch)
2009-06-29 23:53 PDT, Raju Kunnath 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raju Kunnath
Comment 1 2009-06-29 23:53:28 PDT
Created attachment 32034 [details] Windows release build fix
Simon Hausmann
Comment 2 2009-06-30 00:43:16 PDT
Comment on attachment 32034 [details] Windows release build fix Looks good to me. A comment would've been nice explaining _what_ the issue is. I'll add that when landing.
Simon Hausmann
Comment 3 2009-06-30 00:54:03 PDT
Landed in r45367
Note You need to log in before you can comment on or make changes to this bug.