Bug 267519
Summary: | Resize should not be applied to generated content | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | CSS | Assignee: | Ahmad Saleem <ahmad.saleem792> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | karlcow, lea, ntim, webkit-bug-importer |
Priority: | P2 | Keywords: | BrowserCompat, GoodFirstBug, InRadar, WPTImpact |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Ahmad Saleem
Hi Team,
While looking into browser specific failures on WPT.FYI, I noticed that we fail following WPT Test:
WPT Test Case: https://wpt.fyi/results/css/css-ui/resize-generated-content.html?label=experimental&label=master&aligned=
WPT Test Case (Live Link): http://wpt.live/css/css-ui/resize-generated-content.html
Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/2584970
Something like: `style().styleType() != PseudoId::None` needs to be added in our code base:
https://searchfox.org/wubkat/rev/581e116dc6ce254811dbe2da9d1c1168762fc30c/Source/WebCore/style/StyleBuilderConverter.h#797
or
some place else - I don't know where exactly, we need to add this.
Just wanted to raise so we can at least track it.
Thanks!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
or
https://searchfox.org/wubkat/rev/581e116dc6ce254811dbe2da9d1c1168762fc30c/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#702
Tim Nguyen (:ntim)
This isn't super hard to fix.
All the `resize() != Resize::None` need to be consolidated into a single method, and then that method should be augmented to check the pseudoId.
Tim Nguyen (:ntim)
https://searchfox.org/wubkat/search?q=%21%3D+Resize%3A%3ANone&path=&case=false®exp=false
Radar WebKit Bug Importer
<rdar://problem/121348638>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/35642
EWS
Committed 285644@main (35e55ec1b446): <https://commits.webkit.org/285644@main>
Reviewed commits have been landed. Closing PR #35642 and removing active labels.
Ahmad Saleem
*** Bug 135243 has been marked as a duplicate of this bug. ***