Bug 267388

Summary:	[GPU Process] Possible null dereferencing when destroying the cached RenderingResources of a WebPage
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Said Abou-Hallawa

Reported 2024-01-10 18:04:58 PST

The destructor of WebPage calls RemoteResourceCacheProxy::clearRenderingResourceMap() via other calls. Because RemoteResourceCacheProxy stores the cached RenderingResources in a HashMap of WeakPtrs, we need to ensure the WeakPtr of the RenderingResource is not null before using it.

Attachments
Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2024-01-10 18:05:24 PST

rdar://120464355

Said Abou-Hallawa

Comment 2 2024-01-10 18:09:13 PST

Pull request: https://github.com/WebKit/WebKit/pull/22639

EWS

Comment 3 2024-01-11 09:21:15 PST

Committed 272919@main (a71e93715498): <https://commits.webkit.org/272919@main> Reviewed commits have been landed. Closing PR #22639 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.