Bug 267370
| Summary: | [GStreamer] media/media-vp8-webm-error.html is a permanent failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Other | ||
Jean-Yves Avenard [:jya]
Test introduced in bug 267165 is a permanent failure as the MediaPlayerPrivateGStreamer doesn't detect the decoding error (one video sample has been made invalid by having a few 0xFF added)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
Is that test setting the video to play? The decode errors won't happen otherwise.
Philippe Normand
Two issues here:
* https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5916
* GstVideoDecoder doesn't emit error messages to the bus, we'd need to set max-errors=0 on it, and also handle GST_STREAM_ERROR_DECODE properly in handleMessage...
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/22813
EWS
Committed 273410@main (7b9b52800ba5): <https://commits.webkit.org/273410@main>
Reviewed commits have been landed. Closing PR #22813 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/121521205>