Bug 267311

Summary:	Web Inspector: Replace the audit tests to rem instead of px
Product:	WebKit	Reporter:	Frances Cornwall <frances_c>
Component:	Web Inspector	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	inspector-bugzilla-changes, jcraig, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Frances Cornwall

Reported 2024-01-09 20:24:29 PST

The audit tests: AuditContentTestView.css, AuditTestGroupContent.css, and AuditCaseContent.css are using px in the tests. I propose to replace px with em to make the tests more accessible on more devices.

Attachments
Add attachment proposed patch, testcase, etc.

Frances Cornwall

Comment 1 2024-01-10 07:54:26 PST

Pull request: https://github.com/WebKit/WebKit/pull/22563

Frances Cornwall

Comment 2 2024-01-10 17:03:15 PST

Pull request: https://github.com/WebKit/WebKit/pull/22633

James Craig

Comment 3 2024-01-11 13:00:20 PST

Relating bug 146801 and bug 147408

Radar WebKit Bug Importer

Comment 4 2024-01-16 20:25:17 PST

<rdar://problem/121092297>

Frances Cornwall

Comment 5 2024-01-28 12:48:14 PST

Replacing rem with px in the tests for `font-size`.

Frances Cornwall

Comment 6 2024-01-29 17:51:21 PST

px with rem*

Frances Cornwall

Comment 7 2024-01-29 20:18:30 PST

Pull request: https://github.com/WebKit/WebKit/pull/23477

Note You need to log in before you can comment on or make changes to this bug.