Bug 267203
| Summary: | Fix warnings found by compiling with -Wc99-designator and -Wreorder-init-list | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 267387 | ||
David Kilzer (:ddkilzer)
Fix warnings found by compiling with -Wc99-designator and -Wreorder-init-list.
Examples:
Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:181:9: error: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Werror,-Wc99-designator]
181 | .width = width(),
| ^~~~~~~~~~~~~~~~
Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:180:9: note: first non-designated initializer is here
180 | { .codec = codec() },
| ^~~~~~~~~~~~~~~~~~~~
Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:184:9: error: ISO C++ requires field designators to be specified in declaration order; field 'framerate' will be initialized after field 'colorSpace' [-Werror,-Wreorder-init-list]
184 | .colorSpace = colorSpace(),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:183:22: note: previous initialization for field 'framerate' is here
183 | .framerate = framerate(),
| ^~~~~~~~~~~
2 errors generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/120609492>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/22481
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/22485
EWS
Committed 272764@main (b5982fde2d0a): <https://commits.webkit.org/272764@main>
Reviewed commits have been landed. Closing PR #22485 and removing active labels.