Bug 26717

Summary:

box-orient is not inherited

Product:

WebKit

Reporter:

Shinichiro Hamaji <hamaji>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

hamaji, hyatt

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

URL:

https://bugs.webkit.org/attachment.cgi?id=31849

Attachments:

Description	Flags
Test case	none
Patch v1	none
expected png of my layout test	none
Patch v1	none

Shinichiro Hamaji

Reported 2009-06-25 03:48:06 PDT

According to http://dev.w3.org/csswg/css3-flexbox/ , box-orient should be inherited, but they aren't inherited with current WebKit. I'll upload a test case and a patch. Note that this spec seemed to change. As of August 2007, box-orient should NOT be inherited: http://www.w3.org/TR/2007/WD-css3-layout-20070809/#box-orient I'm not sure if the current spec is fixed or tentative. If WebKit developers think we should wait until the spec is fixed, please feel free to mark this bug as won't fix.

Attachments
Test case (420 bytes, text/html) 2009-06-25 03:49 PDT, Shinichiro Hamaji	no flags	Details
Patch v1 (11.20 KB, patch) 2009-06-25 03:56 PDT, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
expected png of my layout test (16.35 KB, image/png) 2009-06-25 04:00 PDT, Shinichiro Hamaji	no flags	Details
Patch v1 (20.14 KB, patch) 2009-06-25 22:00 PDT, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Shinichiro Hamaji

Comment 1 2009-06-25 03:49:08 PDT

Created attachment 31849 [details] Test case

Shinichiro Hamaji

Comment 2 2009-06-25 03:56:57 PDT

Created attachment 31850 [details] Patch v1 LayoutTests/ChangeLog | 20 +++++++++++++++ LayoutTests/fast/flexbox/017.html | 6 ++++ LayoutTests/fast/flexbox/019.html | 6 ++++ LayoutTests/fast/flexbox/box-orient-inherited.html | 25 +++++++++++++++++++ LayoutTests/fast/flexbox/flex-hang.html | 2 +- .../flexbox/box-orient-inherited-expected.checksum | 1 + .../fast/flexbox/box-orient-inherited-expected.png | Bin 0 -> 16746 bytes .../fast/flexbox/box-orient-inherited-expected.txt | 16 ++++++++++++ WebCore/ChangeLog | 26 ++++++++++++++++++++ WebCore/rendering/style/RenderStyle.h | 4 +- WebCore/rendering/style/StyleFlexibleBoxData.cpp | 4 +-- WebCore/rendering/style/StyleFlexibleBoxData.h | 1 - WebCore/rendering/style/StyleRareInheritedData.cpp | 5 +++- WebCore/rendering/style/StyleRareInheritedData.h | 3 +- 14 files changed, 110 insertions(+), 9 deletions(-)

Shinichiro Hamaji

Comment 3 2009-06-25 04:00:29 PDT

Created attachment 31851 [details] expected png of my layout test Please land this png file in LayoutTests/platform/mac/fast/flexbox as well.

Shinichiro Hamaji

Comment 4 2009-06-25 22:00:33 PDT

Created attachment 31905 [details] Patch v1 LayoutTests/ChangeLog | 20 +++++++++++++++ LayoutTests/fast/flexbox/017.html | 6 ++++ LayoutTests/fast/flexbox/019.html | 6 ++++ LayoutTests/fast/flexbox/box-orient-inherited.html | 25 +++++++++++++++++++ LayoutTests/fast/flexbox/flex-hang.html | 2 +- .../flexbox/box-orient-inherited-expected.checksum | 1 + .../fast/flexbox/box-orient-inherited-expected.png | Bin 0 -> 16746 bytes .../fast/flexbox/box-orient-inherited-expected.txt | 16 ++++++++++++ WebCore/ChangeLog | 26 ++++++++++++++++++++ WebCore/rendering/style/RenderStyle.h | 4 +- WebCore/rendering/style/StyleFlexibleBoxData.cpp | 4 +-- WebCore/rendering/style/StyleFlexibleBoxData.h | 1 - WebCore/rendering/style/StyleRareInheritedData.cpp | 5 +++- WebCore/rendering/style/StyleRareInheritedData.h | 3 +- 14 files changed, 110 insertions(+), 9 deletions(-)

Shinichiro Hamaji

Comment 5 2009-06-25 22:01:58 PDT

Comment on attachment 31905 [details] Patch v1 Added the expected image into the patch.

Eric Seidel (no email)

Comment 6 2009-06-26 01:16:59 PDT

Hyatt?

Dave Hyatt

Comment 7 2009-07-06 11:32:00 PDT

I suspect that's a typo... it's not clear to me why box-orient would be inherited. Let me ask dbaron.

Dave Hyatt

Comment 8 2009-07-06 11:32:31 PDT

Comment on attachment 31905 [details] Patch v1 Clearing review flag for now while I try to determine why this changed.

Shinichiro Hamaji

Comment 9 2009-07-06 12:52:07 PDT

It turned out this was just a typo of the spec.

Note You need to log in before you can comment on or make changes to this bug.