Bug 267167 – Remove 'float:none' for computed value for Flex/Grid Items

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Ahmad Saleem]

Hi Team,

While looking into browser specific failures, I noted that we fail two tests:

https://wpt.fyi/results/css/css-display/display-with-float-dynamic.html?label=master&label=experimental&aligned&q=safari%3Afail

https://wpt.fyi/results/css/css-display/display-with-float.html?label=master&label=experimental&aligned=&q=safari%3Afail

> display-with-float-dynamic.html
> display-with-float.html

I noticed that we have computed value as 'None'. Looking into 'Blink' change, I noticed, we have also it in StyleAdjuster.cpp as 'None'.

Removing the line:

https://github.com/WebKit/WebKit/blob/fd569defc022c2d1e03658764ac31816e0267ef1/Source/WebCore/style/StyleAdjuster.cpp#L490

// https://www.w3.org/TR/css-display/#transformations
        // "A parent with a grid or flex display value blockifies the box’s display type."
        if (m_parentBoxStyle.isDisplayFlexibleOrGridBox()) {
            style.setFloating(Float::None);
            style.setEffectiveDisplay(equivalentBlockDisplay(style));
        }

to just:

// https://www.w3.org/TR/css-display/#transformations
        // "A parent with a grid or flex display value blockifies the box’s display type."
        if (m_parentBoxStyle.isDisplayFlexibleOrGridBox()) {
            style.setEffectiveDisplay(equivalentBlockDisplay(style));
        }

___

We start progressing above two tests. I haven't run whole 'css' (WPT suite) or other tests but just wanted to raise bug so we can track and fix it.

Thanks!

[Ahmad Saleem]

It might progress following as well:

flex-legend-float-abspos.html 

fieldset-grid.html 	

fieldset-flexbox.html

[Radar WebKit Bug Importer]

<rdar://problem/120934759>

[Frédéric Wang Nélar]

@Ahmad: I think this is a duplicate of bug 172999 (well, at least for flex items). Indeed, removing the corresponding lines from the the style adjuster would progress some tests for the computed style, but we still need a way to blockifying flex/grid items, otherwise other tests will fail. Maybe what was done in Chromium at https://issues.chromium.org/issues/41093673 can be a source of inspiration, dunno.

[Frédéric Wang Nélar]

*** This bug has been marked as a duplicate of bug 172999 ***

[Frédéric Wang Nélar]

(In reply to Ahmad Saleem from comment #1)
> It might progress following as well:
> 
> flex-legend-float-abspos.html 
> 
> fieldset-grid.html 	
> 
> fieldset-flexbox.html

I'm unsure why, these don't see to test the float computed value? (And the layout should remain the same).