Bug 267163
| Summary: | SelectorPseudo*Map.cpp files contain lots of empty entries | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
See:
https://searchfox.org/wubkat/source/__GENERATED__/WebCore/DerivedSources/SelectorPseudoClassAndCompatibilityElementMap.cpp
https://searchfox.org/wubkat/source/__GENERATED__/WebCore/DerivedSources/SelectorPseudoElementMap.cpp
I failed to notice it when I initially generated the maps.
I'm guessing the data needs to be fed in alphabetical order for gperf to generate efficient maps.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/120567148>
Tim Nguyen (:ntim)
This predates 272549@main and 272544@main, not sure what regressed this, or if it was always this way.
Tim Nguyen (:ntim)
Also pre-dates 272429@main, I guess it's always been like this then...
Tim Nguyen (:ntim)
I’ve tested before 272429@main which is before any substantial changes to code generation happened, so this is probably how gperf is supposed to behave.