Bug 267148
| Summary: | [WebRTC] vp9_encoder.c: error: arithmetic between floating-point type 'double' and enumeration type 'vpx_bit_depth_t' (aka 'enum vpx_bit_depth') | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebRTC | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 267387 | ||
David Kilzer (:ddkilzer)
When WebKit is built with open source clang, -Wenum-float-conversion is enabled by default and finds this issue in update_level_info() from vp9_encoder.c:
```
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_encoder.c:6222:80: error: arithmetic between floating-point type 'double' and enumeration type 'vpx_bit_depth_t' (aka 'enum vpx_bit_depth') [-Werror,-Wenum-float-conversion]
6222 | level_spec->compression_ratio = (double)level_stats->total_uncompressed_size *
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
6223 | cm->bit_depth /
| ~~~~~~~~~~~~~
1 error generated.
```
<rdar://120384890>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/22479
EWS
Committed 272771@main (abf1ad2d9356): <https://commits.webkit.org/272771@main>
Reviewed commits have been landed. Closing PR #22479 and removing active labels.