Bug 267067
| Summary: | Avoid duplicate null check in ReplaceSelectionCommand::pastLastLeaf() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across following:
Blink Commit: https://chromium.googlesource.com/chromium/blink/+/4c63691bebc58be7ff827759a489286b71e6d314
WebKit Source: https://github.com/WebKit/WebKit/blob/62336f941c169dd318b33b40c0879b872533d7f0/Source/WebCore/editing/ReplaceSelectionCommand.h#L84
Following compiles:
Node* pastLastLeaf() const
{
ASSERT(m_lastNodeInserted);
return NodeTraversal::next(*m_lastNodeInserted->lastDescendant());
}
__
Just wanted to raise to get input, if we need to do following change.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 272659@main (eed5354f0af6): <https://commits.webkit.org/272659@main>
Reviewed commits have been landed. Closing PR #22393 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/120497738>