Bug 26704 – bugzilla-tool needs to invoke a specific build-webkit

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

bugzilla-tool needs to invoke a specific build-webkit

Currently it uses the one in your path.  Which might be in a different webkit repository, which means you'll end up buildnig the wrong copy of WebKit.  This is what caused the bad checkins today. :(

It's also wrong to use the build-webkit in the path because not everyone will have build-webkit in their path.

bugzilla-tool is cwd aware, it passes the cwd off to the SCM system and asks it if its a valid SCM checkout and if so, what the root directory of the checkout is.  bugzilla-tool assumes whatever root directory you're in is a WebKit checkout.  This allows me to have multiple webkit checkouts and make modifications to bugzilla-tool in one and test the modified version against other checkouts.

[Eric Seidel (no email)]

Created attachment 31876 [details]
Call WebKitTools/Scripts scripts by their absolute paths

---
 3 files changed, 27 insertions(+), 6 deletions(-)

[Mark Rowe (bdash)]

Comment on attachment 31876 [details]
Call WebKitTools/Scripts scripts by their absolute paths

As mentioned on IRC, the leading underscore on _script_path is inconsistent with the convention used on other methods in the file.  r=me

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/scm.py
Committed r45197
http://trac.webkit.org/changeset/45197