| Summary: | prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or REAL_NAME | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aroben, darin, levin, mrowe | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2009-06-24 14:08:32 PDT
prepare-ChangeLog should take --name= and --email= arguments if it doesn't already. Created attachment 32141 [details]
First attempt
The windows code path might still need some tweaking from one of the windows folks. But this should at least get rid of one more source of needless reviewer timewaste (telling people to fix the names in their ChangeLogs). :) I'm not sure that adding --email= and --name= is actually worth it. I am happy to remove them if the reviewer agrees. It's very easy to do: REAL_NAME="Eric Seidel" prepare-ChangeLog or just as easy as: prepare-ChangeLog --name="Eric Seidel" I think we should be encouraging people to use the environment variables. I initially added --name and --email because I wanted to leave flexibility if I was making prepare-ChangeLog fail more strictly. Created attachment 32144 [details]
Now with more sanity checking
Comment on attachment 32144 [details] Now with more sanity checking > @@ -94,6 +96,8 @@ sub normalizePath($); > # Project time zone for Cupertino, CA, US > my $changeLogTimeZone = "PST8PDT"; > > +my $name; > +my $email_address; > my $gitCommit = 0; > my $gitIndex = ""; You've been infected (cleansed?) by Python. Please use interCaps for variable names. r=me The script uses mixed variable naming styles. email_address is historical... but I've changed it to emailAddress now. Thanks for the review! Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/prepare-ChangeLog Committed r45455 http://trac.webkit.org/changeset/45455 |