Bug 266901
| Summary: | UA Stylesheet adds '1px' border top width for 'iframe' in fullscreen WPT test case | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking into browser specific failures, I noticed that we are failing following Test Case:
WPT Test Case: https://wpt.fyi/results/fullscreen/rendering/ua-style-iframe.html?label=master&label=experimental&aligned&q=fullscreen
WPT Test Live Link: http://wpt.live/fullscreen/rendering/ua-style-iframe.html
It fails in Safari (even WebKit ToT) with following:
> assert_equals("1px", "0px", "fullscreen borderTopWidth style")
I looked into 'fullscreen.css' and we have 'border: none' with !important as well. Similarly, I looked into presentational hints in 'HTMLIframeElement.cpp' and we don't have 1 px (like we had for HR in the past).
I even tried to look into 'html.css' but couldn't find '1 px'. So I am just raising so we can track and fix this issue.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
This seems more like a timing issue, WebKit might be updating styles later than the test expects, but the border-width is correct when you're in fullscreen.
Radar WebKit Bug Importer
<rdar://problem/120386877>
Ahmad Saleem
Fixed via - https://github.com/WebKit/WebKit/commit/cba51d14a79420eea435792f37f3e379bc523bb9#diff-1fd83580913d21fb150911a2a25d0b001c80556841e7cd098cdf46a008de4824
*** This bug has been marked as a duplicate of bug 249069 ***