Bug 266852
| Summary: | Remove -webkit-column-progression and -webkit-column-axis properties | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, karlcow, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking through Blink's commit, I came across another potential clean-up:
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/b8e807bcea9f03c4a4cd7aa4a7fb7e2b7ac7acc2
Just wanted to raise to get input, whether we still have any internal usage or it is safe to remove.
NOTE - I just checked that we have tests but didn't check, if we still have implementation.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
asking around
Radar WebKit Bug Importer
<rdar://problem/120106659>
Karl Dubost
Ahmad, I think these can be safely removed.
I searched and didn't find any instances apart in the codebase of WebKit.
Karl Dubost
https://searchfox.org/wubkat/search?q=WebkitColumnProgression&path=&case=false®exp=false
https://searchfox.org/wubkat/search?q=webkit-column-progression&path=&case=false®exp=false
https://searchfox.org/wubkat/search?q=WebkitColumnAxis&path=&case=false®exp=false
https://searchfox.org/wubkat/search?q=webkit-column-axis&path=&case=false®exp=false
And this is not part of any standards
https://drafts.csswg.org/css-multicol/
The commit blink has also happened 10 years ago.
Karl Dubost
https://caniuse.com/mdn-css_properties_-webkit-column-progression
https://caniuse.com/mdn-css_properties_-webkit-column-axis
no support anywhere.
Ahmad Saleem
Draft PR - https://github.com/WebKit/WebKit/pull/23643 (to check what else fails on EWS)
Karl Dubost
Ahmad, doing a last check internally about dependency on the content.