| Summary: | Media controls should use -webkit-box, to easily support control bar element removal. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pierre d'Herbemont <pdherbemont> | ||||||||||||
| Component: | New Bugs | Assignee: | Pierre d'Herbemont <pdherbemont> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | pdherbemont | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Mac | ||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 26659 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Pierre d'Herbemont
2009-06-23 11:05:02 PDT
Created attachment 31732 [details]
patch 1/2 - v1.
First half of the patch. (Doesn't include layout changes)
Created attachment 31733 [details]
patch 1/2 - v2.
Created attachment 31734 [details]
patch 2/2 - v1.
Attached the test update.
Created attachment 31742 [details]
patch 1/2 - v3.
With changelog and without space between CSS rules.
Created attachment 31743 [details]
patch 2/2 - v2.
This time with a ChangeLog
Comment on attachment 31742 [details]
patch 1/2 - v3.
Fine with me. Obviously you need to update the test results.
Comment on attachment 31743 [details]
patch 2/2 - v2.
r=me
(In reply to comment #7) > (From update of attachment 31742 [details] [review]) > Fine with me. Obviously you need to update the test results. Well, I probably forgot some issues on Windows... I fear that the button might have an extra border there. I'll have to check. On Windows and Mac OS this changes needs to be coordinated with a WebKitSystemInterface change. Pierre, I assume you have commit-bit and will commit these patches yourself? (In reply to comment #11) > Pierre, I assume you have commit-bit and will commit these patches yourself? Nope... I don't have commit access. Pierre. If these are going to change tests, why are the test changes not included in the diffs? (In reply to comment #13) > If these are going to change tests, why are the test changes not included in > the diffs? Well, no special reason. The two patches should be applied and committed at once. Note, simon is taking care of this for now. |