Bug 266300
| Summary: | [GPU Process] Images with certain colorspaces cannot be rendered | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
Open https://en.wikipedia.org/wiki/Wilfrid_Laurier
Result: The image https://commons.wikimedia.org/wiki/File:The_Honourable_Sir_Wilfrid_Laurier_Photo_C_(HS85-10-16873)_-_medium_crop_(cropped).jpg is not displayed.
When transferring the decoded NativeImage to GPUP we have to draw it to ShareableBitmap. To preserve the color space of the image, CGBitmapContextCreateWithData() is called with to create a CGContext with the image color space. CG can't create unaccelerated CGContext for all color spaces. So we fail to transfer the image to GPUP. In fact in debug build, the ASSERT_NOT_REACHED() in RemoteDisplayListRecorder::drawNativeImage() will fire when opening the wikipedia page or image.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://118238178
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/21700
EWS
Committed 273204@main (9d23c40ee7ce): <https://commits.webkit.org/273204@main>
Reviewed commits have been landed. Closing PR #21700 and removing active labels.