Bug 266244
Summary: | REGRESSION(271419@main): [GTK][WPE] Build fails if clang <= 14 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> |
Component: | New Bugs | Assignee: | Diego Pino <dpino> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Diego Pino
WebKitGTK and WPE are failing to build when using clang 14 after 271419@main. This changeset introduced a change that makes use of `std::views::values` in the files:
- Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
- Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h
It seems clang-14 doesn't support `std::views:values`. Here is a small example that fails to build with clang-14:
```
#include <iostream>
#include <map>
#include <ranges>
int main() {
std::map<int, std::string> myMap{
{1, "one"},
{2, "two"},
{3, "three"}
};
for (const auto& value : std::views::values(myMap)) {
std::cout << "Value: " << value << std::endl;
}
return 0;
}
```
Since this feature is only used in these two files in the entire WebKit codebase, I'd like to revert the changes in those two files, so WebKitGTK and WPE can still be built with clang-14.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/21645
EWS
Committed 271921@main (0a646f68779a): <https://commits.webkit.org/271921@main>
Reviewed commits have been landed. Closing PR #21645 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/119549397>