Bug 266040

Summary:	Use WeakRef / WeakPtr to store non-stack RenderObjects
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	Layout and Rendering	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Chris Dumez

Reported 2023-12-07 16:41:31 PST

Use WeakRef / WeakPtr to store non-stack RenderObjects instead of CheckedRef / CheckedPtr. Crashes generated by CheckedRef / CheckedPtr are not actionable if the smart pointer is not on the stack.

Attachments
Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2023-12-07 16:41:43 PST

<rdar://118737861>

Chris Dumez

Comment 2 2023-12-07 16:55:02 PST

Pull request: https://github.com/WebKit/WebKit/pull/21482

EWS

Comment 3 2023-12-08 11:47:45 PST

Committed 271749@main (a94d55eae68f): <https://commits.webkit.org/271749@main> Reviewed commits have been landed. Closing PR #21482 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.